Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: JMicron JMS583 USB-NVMe bridge support #315

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

flowswitch
Copy link

@flowswitch flowswitch commented Jan 11, 2020

The JMS583 firmware supports SCSI SECURITY PROTOCOL IN/OUT commands (relaying them to NVMe side correctly), but it also handles the ATA PASS THROUGH command (in a vendor-specific way, implementing an NVMe pass through), so sedutil gets an empty response to ATA PASS THROUGH (but no command error) and treats the drive as SATA w/o OPAL support without trying the SCSI method.
This patch adds probing the SCSI method in case of empty ATA PASS THROUGH response, so the drive gets detected as SAS at the end and works correctly.

@UtilFunction
Copy link

Why has this pull request not been merged? Maybe @flowswitch can provide binaries?

@Blacklands
Copy link

Blacklands commented May 11, 2023

Why has this pull request not been merged? Maybe @flowswitch can provide binaries?

This repo is very dead, unfortunately. I think @r0m30 has been the only maintainer for a long time, and they're almost or entirely inactive. There's so many things that still need to be done, multiple forks that implement various additional functionality (like sleep support, a better hash function, an updated preboot environment) but nothing gets merged back into here or consolidated elsewhere. I lost track of all the different forks and what they add/improve at this point.
There's also a ton more things in the OPAL spec that sedutil still doesn't support at all (like anything regarding users), and no work is being done on that either.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants