Fix: JMicron JMS583 USB-NVMe bridge support #315
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The JMS583 firmware supports SCSI SECURITY PROTOCOL IN/OUT commands (relaying them to NVMe side correctly), but it also handles the ATA PASS THROUGH command (in a vendor-specific way, implementing an NVMe pass through), so sedutil gets an empty response to ATA PASS THROUGH (but no command error) and treats the drive as SATA w/o OPAL support without trying the SCSI method.
This patch adds probing the SCSI method in case of empty ATA PASS THROUGH response, so the drive gets detected as SAS at the end and works correctly.